Skip to content

Conversation

@EastArctica
Copy link
Collaborator

No description provided.

@EastArctica EastArctica force-pushed the backports/1.21.8-vitepress branch from c6ac5af to a80be23 Compare January 6, 2026 03:53
@EastArctica
Copy link
Collaborator Author

Including parameter names with JSDoc comments is incorrect and should be avoided as per https://jsdoc.app/tags-see.

// Seen in Events.Service (like 757-761)
/**
 * when this service is stopped, this is run...
 * @see EventService#unregisterOnStop(boolean, Registrable[])
 */
stopListener: Packages.xyz.wagyourtail.jsmacros.core.MethodWrapper<any, any, any, any> | null;

Additionally, we may want to use @see {@link EventService#unregisterOnStop} instead of @see EventService#unregisterOnStop for portability and consistency.

@EastArctica
Copy link
Collaborator Author

Typescript doclet should generate a type for pressKeyBind and releaseKeyBind, if not auto generated (may need datagen?), then use a static one.

@JsMacrosCE JsMacrosCE deleted a comment from coderabbitai bot Jan 12, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Important

Review skipped

Too many files!

139 files out of 289 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants