Conversation
stefan-tudor
force-pushed
the
project-refactoring
branch
from
f59fcc4 to
ded3408
Compare
|
| } catch (e: IllegalArgumentException) { | ||
| _effects.tryEmit(DemoFeatureListEffect.ShowError(e.message ?: "An error occurred, please check your settings.")) | ||
| } catch (e: IllegalStateException) { | ||
| _effects.tryEmit(DemoFeatureListEffect.ShowError(e.message ?: "An error occurred, please check your settings.")) |
There was a problem hiding this comment.
Maybe we would like to make it 1-liner function to avoid duplication (line 128 and 130).
| @DisplayName("Given default DeviceRenderOptions when not set, then build() succeeds") | ||
| fun buildUsesDefaultDeviceRenderOptions() { | ||
| val params = validBuilder().build() | ||
| assertNotNull(params) |
There was a problem hiding this comment.
Seems like duplication of the test above.
| .setBillingCountry("GB") | ||
| .setPostCode("SW1A 2AA") | ||
| .setCountryCode(826) | ||
| .setAdministrativeDivision("England") |
There was a problem hiding this comment.
It's a detail, but maybe better provide county as administrative division, not the country. It would be "Greater London" for London. I think it would be slightly less confusing for future devs working on it.
4 participants
No description provided.