Make broadcast extendable to user array wrapper.#1001
Merged
mateuszbaran merged 4 commits intoJuliaArrays:masterfrom Mar 2, 2022
Merged
Make broadcast extendable to user array wrapper.#1001mateuszbaran merged 4 commits intoJuliaArrays:masterfrom
broadcast extendable to user array wrapper.#1001mateuszbaran merged 4 commits intoJuliaArrays:masterfrom
Conversation
5 tasks
N5N3
force-pushed
the
extendbroadcast
branch
2 times, most recently
from
685d0aa to
b16e346
Compare
mateuszbaran
approved these changes
Feb 28, 2022
Collaborator
mateuszbaran
left a comment
mateuszbaran
left a comment
There was a problem hiding this comment.
This looks fine, there should be as little code in generated functions as possible. Constant propagation will have a bit more work to do but it should manage I think.
mateuszbaran
reviewed
Mar 2, 2022
N5N3
added a commit
to N5N3/StaticArrays.jl
that referenced
this pull request
Mar 2, 2022
* Reviewed 1. Make `broadcast` extendable 2. Fix empty case. * Add more test * Bump release. * Test fix
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to make the current broadcast kernal reusable to more wrapped StaticArray.
For this goal, we need to get
first_staticarrayoutside the@generated functionto make sure the type match extendable. (Not sure the reason)Our optimizer should be clever enough to make it zero cost at runtime.
This was discussed in JuliaArrays/StructArrays.jl#215, where we want to make
return a
SVector.A simple test has been added.