Generalize broadcasting to StaticMatrixLike#1220
Merged
mateuszbaran merged 2 commits intoJuliaArrays:masterfrom Nov 17, 2023
Merged
Generalize broadcasting to StaticMatrixLike#1220mateuszbaran merged 2 commits intoJuliaArrays:masterfrom
StaticMatrixLike#1220mateuszbaran merged 2 commits intoJuliaArrays:masterfrom
Conversation
mateuszbaran
approved these changes
Nov 16, 2023
Collaborator
mateuszbaran
left a comment
There was a problem hiding this comment.
This looks reasonable. Could you just bump version to 1.7.0?
Contributor
Author
|
Done 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, broadcasting with
StaticMatrixLike-types does not always returnSMatrixresults:The PR fixes this by generalizing definitions of
BroadcastStyle,isstatic, andaxestoStaticMatrixLike: