improve type stability and runtime performance#194
Merged
piever merged 2 commits intoJuliaArrays:masterfrom Aug 25, 2021
ranocha:hr/performance
Merged
improve type stability and runtime performance#194piever merged 2 commits intoJuliaArrays:masterfrom ranocha:hr/performance
piever merged 2 commits intoJuliaArrays:masterfrom
ranocha:hr/performance
Conversation
This was referenced Aug 24, 2021
Collaborator
|
Thanks for the PR! Did you happen to measure if the compilation overhead when doing |
Contributor
Author
|
Running
Thus, the latency of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to improve the performance of some of our numerical simulation methods for partial differential equations in Trixi.jl. The changes in this PR improve the performance of our methods by ca. 25%. Thus, it would be really great if this could be merged and a new version of StructArrays.jl could be registered.