add reduce(vcat) overload#217
add reduce(vcat) overload#217aplavin wants to merge 1 commit intoJuliaArrays:masterfrom aplavin:patch-1
Conversation
|
I would have thought this should have worked without overloading anything, but I suspect the problem is a missing |
|
Actually, I got somewhat confused: the issue isn't performance, it's that currently |
|
That got a bit stale, I've rebased and cleaned up in #218. Other than a confusing ambiguity (when OffsetArrays are involved), it should be possible to merge it quickly. Feel free to comment there if you have ideas on the OffsetArrays issue. |
|
Thanks for that update! With #218, |
Without it, reduce(vcat) seems to fall back to the general reduce with much worse performance.