Merged
Conversation
Up version
Closed
bkamins
reviewed
Apr 23, 2023
bkamins
approved these changes
Apr 23, 2023
Member
bkamins
left a comment
bkamins
left a comment
There was a problem hiding this comment.
Looks good apart from one small comment.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 1 1
Lines 55 55
=======================================
Hits 53 53
Misses 2 2
☔ View full report in Codecov by Sentry. |
Member
|
@quinnj, @nalimilan - OK to merge? |
nalimilan
approved these changes
May 11, 2023
Member
nalimilan
left a comment
nalimilan
left a comment
There was a problem hiding this comment.
Looks good, thanks! This is the most tested line of the ecosystem. :-)
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rownumberfrom DataFrames. See #60