fix: improve command execution speed #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Benchmarked with the same test code as mentioned in #92. Prior to this change a single invocation of julia> @benchmark redis_list()
BenchmarkTools.Trial: 72 samples with 1 evaluation.
Range (min … max): 41.156 ms … 91.646 ms ┊ GC (min … max): 0.00% … 0.00%
Time (median): 69.845 ms ┊ GC (median): 0.00%
Time (mean ± σ): 69.447 ms ± 10.831 ms ┊ GC (mean ± σ): 0.12% ± 0.68%
▁▁█ ▃▁▁▁
▄▄▆▁▄▄▁▁▁▁▁▁▁▆▁▁▁▁▁▁▁▁▄▁▄▁▄▁▁▇▆███▄████▄▁▄▄▇▇▁▆▄▆▄▁▁▆▁▁▁▄▁▇ ▁
41.2 ms Histogram: frequency by time 88.7 ms <
Memory estimate: 1.47 MiB, allocs estimate: 30083.
julia> @benchmark jedis_list() # Jedis for comparison
BenchmarkTools.Trial: 71 samples with 1 evaluation.
Range (min … max): 42.976 ms … 98.741 ms ┊ GC (min … max): 0.00% … 0.00%
Time (median): 70.391 ms ┊ GC (median): 0.00%
Time (mean ± σ): 70.957 ms ± 15.015 ms ┊ GC (mean ± σ): 0.12% ± 0.79%
▁ ▁ ▁ ▁▃ ▆█ ▃ ▁ ▁
▄█▄█▇▇▁▁▁▁▄▁▁▁▄▁▁▁▄▁▁▁▄█▁██▄██▇█▁▄▄█▁▇▁▁▁▇▇▁▁▇▄▄▇▁█▁▄▇▁▇▁▁▄ ▁
43 ms Histogram: frequency by time 98.1 ms <
Memory estimate: 1.72 MiB, allocs estimate: 42083. |
Command execution speed gets a significant speed boost by avoiding multiple small writes to the socket connection. Using an IOBuffer to collect the command args and do a single socket write. Also turned off nagle and turned on quickack on sockets, suitable for the typically short and quick exchanges needed here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 73.59% 73.88% +0.29%
==========================================
Files 6 6
Lines 356 360 +4
==========================================
+ Hits 262 266 +4
Misses 94 94 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@jkaye2012 hope this looks good to merge? |
Collaborator
|
I will take a look this weekend
…On Thu, Nov 30, 2023 at 5:19 AM Tanmay Mohapatra ***@***.***> wrote:
@jkaye2012 <https://github.com/jkaye2012> hope this looks good to merge?
—
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7FL7GGJ6ZHVLCAPJ3PRH3YHB2TZAVCNFSM6AAAAAA764FMZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTGY2TSOBUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command execution speed gets a significant speed boost by avoiding multiple small writes to the socket connection. Using an IOBuffer to collect the command args and do a single socket write. Also turned off nagle and turned on quickack on sockets, suitable for the typically short and quick exchanges needed here.
fixes: #92