Skip to content

Conversation

@tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented Dec 4, 2023

Fixed a typo in error handling code.
Minor change to use === for equality with nothing.

Fixed a typo in error handling code.
Minor change to use `===` for equality with `nothing`.
@tanmaykm tanmaykm changed the title fix: typo in error log fix: typo in error handling Dec 4, 2023
@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cd48768) 73.59% compared to head (c334d8a) 73.59%.
Report is 2 commits behind head on master.

❗ Current head c334d8a differs from pull request most recent head 0eff6b9. Consider uploading reports for the commit 0eff6b9 to get more accurate results

Files Patch % Lines
src/client.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   73.59%   73.59%           
=======================================
  Files           6        6           
  Lines         356      356           
=======================================
  Hits          262      262           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanmaykm
Copy link
Member Author

tanmaykm commented Dec 4, 2023

The codecov check failure in CI doesn't seem too important, no new code lines were added in this PR.

@jkaye2012
Copy link
Collaborator

Might be worth disabling the coverage % check? I like having the coverage reported, but I'm not sure that a minimum bar per diff makes sense as you've said.

@tanmaykm
Copy link
Member Author

tanmaykm commented Dec 4, 2023

Okay, with 0eff6b9 codecov should report but not fail the CI

@tanmaykm
Copy link
Member Author

I guess we can merge this if there are no further comments?

@tanmaykm tanmaykm merged commit 5caa605 into master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants