Fix tuple behavior in pushforward_function and pullback_function#100
Closed
gdalle wants to merge 1 commit intoJuliaDiff:masterfrom
gdalle:fix_tuple_behavior
Closed
Fix tuple behavior in pushforward_function and pullback_function#100gdalle wants to merge 1 commit intoJuliaDiff:masterfrom gdalle:fix_tuple_behavior
gdalle wants to merge 1 commit intoJuliaDiff:masterfrom
gdalle:fix_tuple_behavior
Conversation
Merged
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 84.25% 85.07% +0.81%
==========================================
Files 8 8
Lines 470 469 -1
==========================================
+ Hits 396 399 +3
+ Misses 74 70 -4
☔ View full report in Codecov by Sentry. |
Closed
Member
|
Closing this in favour of #102. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #99
Needs tests to ensure non-regression
Probably useless after #93 but could be merged into it
Tried to make the code a bit more readable by avoiding chained anonymous functions