Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 82.82% 82.94% +0.12%
==========================================
Files 8 8
Lines 425 428 +3
==========================================
+ Hits 352 355 +3
Misses 73 73
☔ View full report in Codecov by Sentry. |
gdalle
approved these changes
Sep 22, 2023
Member
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
I've wanted to do it myself for a while ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a big fan of JuliaFormatter, in particular when working together with others. It makes it just easier to focus on the content instead of having to deal with formatting preferences and changes.
In this PR I set up JuliaFormatter and a Github action that makes formatting suggestions in PRs (used e.g., in ChainRules, JuliaGaussianProcesses, some Turing packages (IIRC), and some of my packages). I went for Blue style because I use that often but I'm also fine with other styles (just not a fan of the long lines and strange indentation in the SciML format 😛).