Skip to content

Fix docs#115

Merged
devmotion merged 1 commit intomasterfrom
dw/docs
Oct 6, 2023
Merged

Fix docs#115
devmotion merged 1 commit intomasterfrom
dw/docs

Conversation

@devmotion
Copy link
Member

The PR tries to fix the build failure on the master branch (see #112 (comment)).

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0559f3b) 82.94% compared to head (e50e525) 82.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files           8        8           
  Lines         428      428           
=======================================
  Hits          355      355           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion requested a review from gdalle October 5, 2023 21:56
@gdalle
Copy link
Member

gdalle commented Oct 6, 2023

I think we should just keep 0.6 since the docs will no longer be accurate for 0.5? Or remove the project entry altogether as you suggested, honestly it's fine either way. It's too small an issue to waste time debating it

@devmotion
Copy link
Member Author

Just removing it won't play nicely with CompatHelper (and without any compat entries at all docs might break at any time, as happened in multiple repos with Documenter 1). So I guess the best is to just use 0.6.

@devmotion
Copy link
Member Author

Ah wait, that also won't work with XompatHelper - it will reopen PRs for 0.5. So 0.5, 0.6 is the best option I think.

@devmotion devmotion merged commit 5166a90 into master Oct 6, 2023
@devmotion devmotion deleted the dw/docs branch October 6, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants