Skip to content

Run CI on tags#118

Merged
gdalle merged 6 commits intomasterfrom
gd/docsbuild
Oct 16, 2023
Merged

Run CI on tags#118
gdalle merged 6 commits intomasterfrom
gd/docsbuild

Conversation

@gdalle
Copy link
Member

@gdalle gdalle commented Oct 12, 2023

Hopefully fixes the lack of a stable docs build

@gdalle gdalle requested a review from devmotion October 12, 2023 16:58
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d36bb00) 82.94% compared to head (45fbe16) 82.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files           8        8           
  Lines         428      428           
=======================================
  Hits          355      355           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion
Copy link
Member

devmotion commented Oct 12, 2023

Why don't we have a separate Docs.yml action? There's no need to rerun CI tests on tags, we only need the docs.

@gdalle
Copy link
Member Author

gdalle commented Oct 12, 2023

I guess it doesn't hurt to prove that the tests pass specifically for the tag you want. Otherwise if you wanna check you have to go back in time and look for the tests of the associated commit. But I don't feel strongly about either option

@devmotion
Copy link
Member

I think it's sufficient to run CI once for every commit. If you go to a tag, you also end up with the commit with the CI runs next to it.

@gdalle
Copy link
Member Author

gdalle commented Oct 12, 2023

Alright, I'll split out a docs workflow tomorrow

gdalle and others added 2 commits October 15, 2023 19:20
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@gdalle gdalle requested a review from devmotion October 15, 2023 17:34
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gdalle gdalle merged commit 211b675 into master Oct 16, 2023
@gdalle gdalle deleted the gd/docsbuild branch October 16, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants