Skip to content

Fix docstring for value_and_pullback_function#125

Merged
gdalle merged 3 commits intomasterfrom
gd/fix_value_pb
Jan 11, 2024
Merged

Fix docstring for value_and_pullback_function#125
gdalle merged 3 commits intomasterfrom
gd/fix_value_pb

Conversation

@gdalle
Copy link
Member

@gdalle gdalle commented Dec 21, 2023

Fix the docstring of value_and_pullback_function to solve #124 and #119

Clarify that

  • value_and_pushforward_function means (value and pushforward) function
  • value_and_pullback_function means value and (pullback function)

Name some anonymous functions in the process to make the code more readable

@codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (211b675) 82.94% compared to head (5ef52c2) 82.55%.

Files Patch % Lines
src/AbstractDifferentiation.jl 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   82.94%   82.55%   -0.39%     
==========================================
  Files           8        8              
  Lines         428      430       +2     
==========================================
  Hits          355      355              
- Misses         73       75       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Fix docstring for value_and_pullback_function Fix docstring for value_and_pullback_function Dec 21, 2023
@gdalle gdalle requested a review from devmotion January 10, 2024 12:11
@gdalle gdalle merged commit afec712 into master Jan 11, 2024
@devmotion devmotion deleted the gd/fix_value_pb branch February 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

value_and_pullback_function doesn't do what its docstring says Inconsistency in value_and_pushforward_function vs value_and_pullback_function outputs

2 participants