Skip to content

Remove duplicate methods of value_and_hessian#126

Merged
devmotion merged 1 commit intoJuliaDiff:masterfrom
adrhill:ah/duplicate
Jan 7, 2024
Merged

Remove duplicate methods of value_and_hessian#126
devmotion merged 1 commit intoJuliaDiff:masterfrom
adrhill:ah/duplicate

Conversation

@adrhill
Copy link
Contributor

@adrhill adrhill commented Dec 21, 2023

Remove duplicate methods of value_and_hessian and value_gradient_and_hessian for HigherOrderBackends.

These two methods are duplicates of the implementations for AbstractBackends.
Since HigherOrderBackend is an AbstractBackend, they are not required.

@codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (211b675) 82.94% compared to head (9c81c3c) 82.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   82.94%   82.72%   -0.22%     
==========================================
  Files           8        8              
  Lines         428      411      -17     
==========================================
- Hits          355      340      -15     
+ Misses         73       71       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion merged commit 19e7d88 into JuliaDiff:master Jan 7, 2024
@adrhill adrhill deleted the ah/duplicate branch January 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants