Use value_and_pullback_function as a primitive#36
Use value_and_pullback_function as a primitive#36sethaxen wants to merge 4 commits intoJuliaDiff:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 80.05% 78.48% -1.57%
==========================================
Files 2 2
Lines 396 395 -1
==========================================
- Hits 317 310 -7
- Misses 79 85 +6
Continue to review full report at Codecov.
|
|
This PR needs more thinking. I think when using the Jacobian as a primitive, deriving the |
|
Ah sorry I meant to comment on the other PR. Anyways, I suggest merging this PR and #34 and updating the README once. |
I assume you mean #35? That PR already updates the ReadMe for the redefinition of |
|
I want to take a stab at this myself if you don't mind. I will open another PR. |
|
@devmotion should we close this one? |
|
Probably. We can always re-open if it is preferred over #93. |
* Define value_and_pullback_function as returning value * Update definition of Jacobian * Update tests * Update API definition * Increment minor version number * Make value_and_oullback_function the primitive * Define pullback_function in terms of value_and_pullback_function * Define value_and_pullback_function in tests * Increment version number * Use value_and_pb_function in CRC and Tracker extensions * Fix bug in Tracker backend * More updates * Fix end * Handle `nothing` * Fix test failures * Use named functions --------- Co-authored-by: Seth Axen <seth.axen@gmail.com> Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com>
Fixes #34. Breaking change marked with
-DEVversion number in case it is merged before #35.