Conversation
| - push | ||
| - pull_request | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
Perhaps we should also run on tagged versions?
| branches: [master] | |
| branches: [master] | |
| tags: [v*] |
There was a problem hiding this comment.
I don't mind. But I don't think it is necessary - it is run for every commit pushed to the master branch anyway. I think the tags trigger is mainly useful for building release-specific documentation.
There was a problem hiding this comment.
We'll want that eventually anyways, once we have documentation. I'll leave it up to you whether to add it.
There was a problem hiding this comment.
For documentation we might want to add a separate action anyway, IMO that's cleaner (and e.g. allows more fine-tuned triggers) 🤷
There was a problem hiding this comment.
I don't add the trigger in this PR, we can add it later if it seems useful.
| concurrency: | ||
| # Skip intermediate builds: always. | ||
| # Cancel intermediate builds: only if it is a pull request build. | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }} |
There was a problem hiding this comment.
Ah, I hadn't seen this done before. I assume you've seen it in action and it works as documented.
There was a problem hiding this comment.
Yeah, it's used all over the place (e.g. ChainRulesCore: https://github.com/JuliaDiff/ChainRulesCore.jl/blob/3e11e627b5a10a3149902b2c538be63c61ecafbc/.github/workflows/CI.yml#L10-L14) and part of PkgTemplates (https://github.com/invenia/PkgTemplates.jl/blob/1cb56bf90326d47c402af51537c9c669e9b08a24/templates/github/workflows/CI.yml#L10-L14).
2 participants
This PR
pushandpull_requestevent (as e.g. in Retrieve pullback only once for ReverseRuleConfigBackend #51)