Do not load StaticArrays in ForwardDiff backend#75
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 83.33% 83.82% +0.49%
==========================================
Files 6 6
Lines 474 476 +2
==========================================
+ Hits 395 399 +4
+ Misses 79 77 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ChrisRackauckas
approved these changes
Feb 28, 2023
Member
|
ForwardDiff needs to specialize on StaticArrays in order to switch effectively between mutable and immutable diffresults internally. But for AbstractDifferentiation I think the "allocating forms" just hit all of the right StaticArray dispatches so it just works nicely. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not obvious to me why StaticArrays is loaded in forwarddiff.jl, so let's try to remove it.
Fixes #73.