New Zygote context in every call to AD.pullback_function#77
New Zygote context in every call to AD.pullback_function#77
AD.pullback_function#77Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 84.36% 84.25% -0.12%
==========================================
Files 8 8
Lines 467 470 +3
==========================================
+ Hits 394 396 +2
- Misses 73 74 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I made the fix more modular in 848ee38, to avoid code duplication and make it easy to apply similar fixes for other AD backends if needed. |
|
Well, that eliminates my only substantive point in #76 (comment). As the adage goes, the fastest way to get something done is to do it wrong and get someone to correct it for you 😆 |
|
That is, you approve this PR? 🙂 |
ToucheSir
left a comment
There was a problem hiding this comment.
Yes, though I'm not sure how much weight it carries here :)
|
I trust your Zygote expertise 🙂 |
JuliaDiff#77 doesnt seem to solve it
Alternative to #76 that I had in mind when writing #76 (review).
In contrast to #76, with this PR
ZygoteBackendwould still be aReverseRuleConfigBackend, and hence the behaviour ofZygoteBackendandReverseRuleConfigBackend(Zygote.ZygoteRuleConfig())would not differ.Fixes #69. Closes #70. Closes #76.