Add complex tests and fix rules for BLAS functions#220
Merged
sethaxen merged 16 commits intoJuliaDiff:masterfrom Jun 30, 2020
Merged
Add complex tests and fix rules for BLAS functions#220sethaxen merged 16 commits intoJuliaDiff:masterfrom
sethaxen merged 16 commits intoJuliaDiff:masterfrom
Conversation
sethaxen
added
the
blocked
willtebbutt
approved these changes
Jun 30, 2020
Member
willtebbutt
left a comment
willtebbutt
left a comment
There was a problem hiding this comment.
LGTM. Just a couple of style things -- I wouldn't reject as is though.
sethaxen
removed
the
blocked
Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #210, this PR fixes #214 by adding missing complex tests for all rules for
BLASfunctions and fixing the rules where necessary. This should be the last piece of v0.7.0.This PR uses the utility functions from #216, so it is blocked by that PR. Locally all tests pass.