Merged
Conversation
github-actions
bot
added
the
needs version bump
oxinabox
approved these changes
May 27, 2021
willtebbutt
approved these changes
May 27, 2021
Member
willtebbutt
left a comment
willtebbutt
left a comment
There was a problem hiding this comment.
LGTM. Just needs a patch bump.
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 23 23
Lines 1929 1929
=======================================
Hits 1900 1900
Misses 29 29 Continue to review full report at Codecov.
|
Member
Author
It's just tests right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two tests implicitly assume that
NO_FIELDSis aZeroTangent. This PR removes this assumption to make way for JuliaDiff/ChainRulesCore.jl#358