fix #422: nightly failures due to instabilities#431
Closed
simeonschaub wants to merge 1 commit intomasterfrom
Closed
fix #422: nightly failures due to instabilities#431simeonschaub wants to merge 1 commit intomasterfrom
simeonschaub wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
needs version bump
nickrobinson251
approved these changes
Jun 2, 2021
oxinabox
reviewed
Jun 2, 2021
| @test Ḟ_ad.values ≈ Ḟ_fd.values | ||
| @test Ḟ_ad.vectors ≈ Ḟ_fd.vectors | ||
| @test frule((ZeroTangent(), ZeroTangent()), eigen!, copy(X)) == (F, ZeroTangent()) | ||
| @test frule((ZeroTangent(), ZeroTangent()), eigen!, copy(X)) ≈ (F, ZeroTangent()) |
Member
There was a problem hiding this comment.
≈ doesn't work on tuples.
And is deprecated on AbstractTangents
I think instead use the test_approx from ChainRulesTestUtils.
Similar above.
Suggested change
| @test frule((ZeroTangent(), ZeroTangent()), eigen!, copy(X)) ≈ (F, ZeroTangent()) | |
| test_approx(frule((ZeroTangent(), ZeroTangent()), eigen!, copy(X)), (F, ZeroTangent())) |
simeonschaub
added a commit
to JuliaDiff/ChainRulesTestUtils.jl
that referenced
this pull request
Jun 2, 2021
This is needed for JuliaDiff/ChainRules.jl#431.
simeonschaub
added a commit
to JuliaDiff/ChainRulesTestUtils.jl
that referenced
this pull request
Jun 2, 2021
This is needed for JuliaDiff/ChainRules.jl#431.
simeonschaub
force-pushed
the
sds/fix_eigen_instabilities
branch
from
97ecc89 to
7d18f6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 21 21
Lines 1984 1984
=======================================
Hits 1952 1952
Misses 32 32 Continue to review full report at Codecov.
|
Member
Author
|
Superseded by JuliaLang/julia#41132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.