Add nondiff rules for one ones zero zeros#465
Conversation
|
This was also mentioned in FluxML/Zygote.jl#780 by @oxinabox. Should these rather return |
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 21 21
Lines 2201 2201
=======================================
Hits 2168 2168
Misses 33 33
Continue to review full report at Codecov.
|
|
I suppose but they work almost identically so I would favour the simplicity of using a macro over being pedantic in this case. |
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
|
Thanks for the PR! Will merge when CI passes. Just FYI, it's possible to commit the code suggestions all at once, which prevents CI from running for each suggestion. I think there is a limit to how many jobs can be run per organisation at the same time, and ChainRules tests take a while so a queue forms sometimes. |
|
Thanks @mzgubic ! |
Porting nograd rules for
one,ones,zero,zerosfrom Zygote https://github.com/FluxML/Zygote.jl/blob/master/src/lib/array.jl#L11Follow-up to #252