Skip to content

shave another 7 mins off tests#499

Merged
simeonschaub merged 2 commits intomasterfrom
sds/nospecialize
Aug 13, 2021
Merged

shave another 7 mins off tests#499
simeonschaub merged 2 commits intomasterfrom
sds/nospecialize

Conversation

@simeonschaub
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Aug 13, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #499 (50706b4) into master (47df5cf) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   98.12%   98.13%           
=======================================
  Files          22       22           
  Lines        2351     2353    +2     
=======================================
+ Hits         2307     2309    +2     
  Misses         44       44           
Impacted Files Coverage Δ
src/rulesets/LinearAlgebra/factorization.jl 97.08% <0.00%> (+<0.01%) ⬆️
src/rulesets/Base/fastmath_able.jl 98.31% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47df5cf...50706b4. Read the comment docs.

@oxinabox
Copy link
Copy Markdown
Member

How?I don't understand

@simeonschaub simeonschaub changed the title shave another 4 mins off tests shave another <s>4</s>7 mins off tests Aug 13, 2021
@simeonschaub simeonschaub changed the title shave another <s>4</s>7 mins off tests shave another 7 mins off tests Aug 13, 2021
@simeonschaub simeonschaub requested a review from oxinabox August 13, 2021 10:13
@simeonschaub
Copy link
Copy Markdown
Member Author

How?I don't understand

We do define a bunch of top-level as well as anonymous functions inside the test, which is probably what adds up.

I have pushed some changes to infer even less, which saves us another 3 minutes or so.

@nospecialize

if isdefined(Base, :Experimental) && isdefined(Base.Experimental, Symbol("@compiler_options"))
@eval Base.Experimental.@compiler_options compile=min optimize=0 infer=no
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask to this line how this works? I am trying to use this in my code and it seems to not work (compared to starting Julia with those settings as command line parameters). Is there a trick to make this work?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants