Merged
Conversation
oxinabox
commented
Sep 21, 2023
test/rulesets/Base/indexing.jl
Outdated
Comment on lines
+6
to
+10
| test_frule(getfield, Foo(1.5, 2.5), :x, check_inferred=false) | ||
|
|
||
| test_frule(getfield, (; a=1.5, b=2.5), :a, check_inferred=false) |
Member
Author
There was a problem hiding this comment.
These actually infer fine as long as the frule gets inlined somewhere where the symbol is known at compile time.
I.e. almost all uses hopefully.
oxinabox
force-pushed
the
ox/getfield
branch
from
6ff71ee to
84cd7be
Compare
Member
Author
|
Apparently these CI failures are real. |
3 tasks
oscardssmith
approved these changes
Oct 2, 2023
Member
oscardssmith
left a comment
oscardssmith
left a comment
There was a problem hiding this comment.
This looks good to me (other than the fact that CI is unhappy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This are taken directly from another project.
Suprising we didn't have them already