Overhaul Rules (partner PR) by oxinabox · Pull Request #91 · JuliaDiff/ChainRules.jl

oxinabox · 2019-08-27T18:22:52Z

This is the matching changes for
JuliaDiff/ChainRulesCore.jl#30

Before reviewing you are recommended to read the Docs PR buddy of this:
#103

proto.jl

Project.toml

src/rulesets/Base/base.jl

test/test_util.jl

nickrobinson251 · 2019-09-03T12:43:49Z

test/test_util.jl

    end
 end

+function ensure_not_running_on_functor(f, name)


this is temporary and will change in future? let's comment that?

Not super soon,
@test_scalar would need a lot of work to handle functors.

yeah, i'm fine with that... maybe we should have an issue tracking that and link to it here?

it certainly is on the long-term plan (although someone might need to want it enough for it to actually happen)

test/test_util.jl

src/rulesets/Base/array.jl

oxinabox · 2019-09-06T18:44:37Z

Status update:
basically everrything is done except:

src/rulesets/LinearAlgebra/blas.jl
- which needs:
  - testing still
  - sorting out update rules
/src/rulesets/LinearAlgebra/factorization.jl
- which I've not touched
- is probably most fiddly

oxinabox · 2019-09-10T14:29:49Z

Everything is done accept sorting out things that accumulate inplace.
Which we don’t actually need.
Considering maybe we should merge as is an make a follow up PR?
Probably not. idk. (edited)
I really need to pair with someone and work that all out

Scalar functions changed over

Temp comment out all accumulate related tests

passing

src/rulesets/LinearAlgebra/dense.jl

nickrobinson251

looking good

since there are so many changes I'll try to review again - probably once the "un-named returns" stuff is fixed up since I think that the last notable thing left?

src/rulesets/LinearAlgebra/dense.jl

src/rulesets/LinearAlgebra/factorization.jl

test/rulesets/LinearAlgebra/dense.jl

test/rulesets/LinearAlgebra/factorization.jl

test/rulesets/Statistics/statistics.jl

test/rulesets/LinearAlgebra/factorization.jl

src/helper_functions.jl

Co-Authored-By: Nick Robinson <npr251@gmail.com>

oxinabox · 2019-09-19T10:01:41Z

This should be good to go now

nickrobinson251

I have reviewed the source
feels good

mostly some tiny style suggestions

will review tests later today

src/rulesets/LinearAlgebra/blas.jl

src/rulesets/LinearAlgebra/dense.jl

src/rulesets/LinearAlgebra/structured.jl

src/rulesets/Base/mapreduce.jl

src/rulesets/LinearAlgebra/blas.jl

Co-Authored-By: Nick Robinson <npr251@gmail.com>

nickrobinson251

Let's do this

test/rulesets/Base/base.jl

Co-Authored-By: Nick Robinson <npr251@gmail.com>

oxinabox force-pushed the ox/wrtfunction branch 2 times, most recently from cab0e9e to f564800 Compare August 30, 2019 15:55

This was referenced Sep 2, 2019

Move Base functions out of /LinearAlgebra/dense.jl #97

Open

Overhaul Rules JuliaDiff/ChainRulesCore.jl#30

Merged

oxinabox changed the title ~~[WIP] include dervative WRT self.~~ Overhaul Rules (partner PR) Sep 2, 2019

oxinabox commented Sep 2, 2019

View reviewed changes

proto.jl Outdated Show resolved Hide resolved

nickrobinson251 reviewed Sep 3, 2019

View reviewed changes

oxinabox added 20 commits September 11, 2019 12:49

[WIP] include dervative WRT self.

366d983

Scalar functions changed over

wip

4e9e330

WIP

4f641d6

[WIP] make changes to all the rules to return WRT self

c575895

Temp comment out all accumulate related tests

comment out more accumulate

0624600

WIP:

6c7478d

all real scalar rules working

05d0c06

Wirtinger scalars passing

7818a63

all tests in tests/rulesets/Base/base.jl

1a43009

passing

Fixup Base tests to match frule not returning a tuple

6592c95

attay test passing

74434c5

Broadcast fixed

1937ec1

WIP fixing up mapreduce file

facf994

make structured and dense rulesets pass

9849149

BLAS written but need to re-sort out update rules before done proper

908b7ea

BLAS rules working but update accumulation inplace is diabled

68c89e2

Factorizations working

33ae54e

Make statistics work

dff859a

remove double extern

a434f2a

fix bad rebase

aafadfa

oxinabox force-pushed the ox/wrtfunction branch from f002d6e to aafadfa Compare September 11, 2019 12:04

oxinabox mentioned this pull request Sep 12, 2019

introdocs + demo + instructions on writing good rules #103

Merged

tkf mentioned this pull request Sep 13, 2019

Make sensitivities for structured matrix arguments structured #52

Open

oxinabox commented Sep 17, 2019

View reviewed changes

src/rulesets/LinearAlgebra/dense.jl Outdated Show resolved Hide resolved

nickrobinson251 reviewed Sep 17, 2019

View reviewed changes

oxinabox commented Sep 17, 2019

View reviewed changes

src/helper_functions.jl Outdated Show resolved Hide resolved

oxinabox and others added 13 commits September 17, 2019 18:57

style and typos

8980926

Co-Authored-By: Nick Robinson <npr251@gmail.com>

use _fdm rather than making a new central_fdm

8c1e418

Co-Authored-By: Nick Robinson <npr251@gmail.com>

set version correctly

b5d3ba9

Co-Authored-By: Nick Robinson <npr251@gmail.com>

name some pullbacks

9eee9db

name more propagators

1288748

More named propagators

f2e5705

Name more propagators

a566a0d

More named propagators

85d0fa0

delete extra unused _update! methods

0f9b3ac

name more progators

cc9028d

fix up typos and extern new thunks in tests

add271f

test nonsquares

3dbdbfc

more named propagators

6ca8deb

nickrobinson251 reviewed Sep 19, 2019

View reviewed changes

oxinabox commented Sep 19, 2019

View reviewed changes

src/rulesets/Base/mapreduce.jl Outdated Show resolved Hide resolved

oxinabox commented Sep 19, 2019

View reviewed changes

src/rulesets/Base/mapreduce.jl Outdated Show resolved Hide resolved

oxinabox commented Sep 19, 2019

View reviewed changes

src/rulesets/LinearAlgebra/blas.jl Outdated Show resolved Hide resolved

oxinabox and others added 2 commits September 19, 2019 18:08

Apply suggestions from code review

320dba0

Co-Authored-By: Nick Robinson <npr251@gmail.com>

more named propagators

c3c20f6

nickrobinson251 approved these changes Sep 19, 2019

View reviewed changes

test/rulesets/Base/base.jl Outdated Show resolved Hide resolved

Update test/rulesets/Base/base.jl

bcb24db

Co-Authored-By: Nick Robinson <npr251@gmail.com>

oxinabox merged commit c8d01a3 into master Sep 19, 2019

YingboMa deleted the ox/wrtfunction branch December 24, 2019 17:00

nickrobinson251 mentioned this pull request Jan 4, 2020

Make tests independent of Turing TuringLang/DynamicPPL.jl#18

Closed

Conversation

oxinabox commented Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickrobinson251 Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

oxinabox Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

nickrobinson251 Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

oxinabox commented Sep 6, 2019

Uh oh!

oxinabox commented Sep 10, 2019

Uh oh!

Uh oh!

nickrobinson251 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oxinabox commented Sep 19, 2019

Uh oh!

nickrobinson251 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickrobinson251 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oxinabox commented Aug 27, 2019 •

edited

Loading