Conversation
Member
|
I assume that the motivation for this is just that |
nickrobinson251
force-pushed
the
npr/rename-dne-doesnotexit
branch
from
e22e1f0 to
71c23b7
Compare
nickrobinson251
force-pushed
the
npr/rename-dne-doesnotexit
branch
from
71c23b7 to
575341d
Compare
Member
|
I am trying to decide if should release ChainRulesCore.jl v0.4.0 |
Contributor
Author
contains some good stuff |
Member
|
good point, releasing |
oxinabox
force-pushed
the
npr/rename-dne-doesnotexit
branch
from
dbed8f1 to
3097e66
Compare
oxinabox
approved these changes
Oct 28, 2019
oxinabox
previously requested changes
Oct 28, 2019
Member
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
Requires breaking version bump, if tyhis is actually breaking
oxinabox
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNE->DoesNotExistChainRulesCore.jl#42is breakingNot now ChainrulesCore uses@deprecate_binding