Make scalar_rule's frule return a Composite not a tuple#214
Merged
Conversation
nickrobinson251
approved these changes
Sep 3, 2020
Contributor
nickrobinson251
left a comment
nickrobinson251
left a comment
There was a problem hiding this comment.
Do any docs need updating following this change?
Member
Author
|
I hope the docs already say that this is what they should do. |
Contributor
Can you do a quick double-check? |
Member
Author
|
You win this time. My hopes were dashed |
oxinabox
force-pushed
the
ox/scalarmultiple
branch
from
4d5771c to
be04497
Compare
oxinabox
force-pushed
the
ox/scalarmultiple
branch
from
be04497 to
52ca7d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #211
I am marking this as a patch, because I think #211 was a bug.
And this shoul;dn't break anyway as
Composite{Tuple}acts just like a tuple for most purposes