Fix error of @non_differentiable on Julia 1.5.0 and 1.5.1 (#328)#329
Merged
devmotion merged 2 commits intoJuliaDiff:masterfrom Apr 3, 2021
Merged
Fix error of @non_differentiable on Julia 1.5.0 and 1.5.1 (#328)#329devmotion merged 2 commits intoJuliaDiff:masterfrom
@non_differentiable on Julia 1.5.0 and 1.5.1 (#328)#329devmotion merged 2 commits intoJuliaDiff:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 13 13
Lines 472 472
=======================================
Hits 424 424
Misses 48 48
Continue to review full report at Codecov.
|
Member
|
Ah, sorry, didn't know you were working on a fix. I don't think we really need to support these versions, but since this is an easy fix, we might as well do this. |
simeonschaub
approved these changes
Apr 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
The underlying problem is JuliaLang/julia#37134 which exists on Julia 1.5.0 and 1.5.1, and was fixed in Julia 1.5.2 (JuliaLang/julia#37181).
I did not add any tests since the error is reproducible only with these Julia versions which currently are not tested on Github.