precompile package callback

[simeonschaub]

With this PR:

(ChainRulesCore) pkg> precompile
Precompiling project...
  1 dependency successfully precompiled in 2 seconds (1 already precompiled)

julia> @time using ChainRulesCore
  0.082255 seconds (157.13 k allocations: 9.737 MiB, 5.59% compilation time)

Before:

julia> @time using ChainRulesCore
  0.111551 seconds (443.47 k allocations: 25.618 MiB, 3.87% compilation time)

Removing the hook alltogether:

julia> @time using ChainRulesCore
  0.033357 seconds (36.37 k allocations: 2.399 MiB, 17.75% compilation time)

That's still more overhead than I'd like, so we should still discuss
whether we could avoid these hooks, but it does at least improve the current
situation somewhat.

Ref #340

[codecov-commenter]

Codecov Report

Merging #341 (bea0985) into master (fe69977) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   90.00%   90.01%   +0.01%     
==========================================
  Files          14       14              
  Lines         540      541       +1     
==========================================
+ Hits          486      487       +1     
  Misses         54       54              

Impacted Files	Coverage Δ
src/ChainRulesCore.jl	100.00% <ø> (ø)
src/ruleset_loading.jl	95.83% <100.00%> (+0.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe69977...bea0985. Read the comment docs.

[oxinabox]

Nice.
We can talk about removing this in #340 (and as to if that is breaking)

But for now this seems good

[oxinabox]

Don't for get to bump the version and tag a release

[oxinabox]

Can we put this in a seperate file?
precompile.jl

We should probably be precompiling a bunch of things

[simeonschaub]

Ok, will do

[KristofferC]

What's the timing on putting these stuff inside its own module and setting @eval Base.Experimental.@compiler_options compile=min optimize=0 infer=false?

[simeonschaub]

What's the timing on putting these stuff inside its own module and setting @eval Base.Experimental.@compiler_options compile=min optimize=0 infer=false?

julia> @time using ChainRulesCore
  0.104489 seconds (97.03 k allocations: 5.980 MiB, 3.87% compilation time)

So it takes a little longer than with this PR, but allocations go down.

[KristofferC]

Hm, I wonder what still takes so much time...

[simeonschaub]

Not sure, profiling wasn't very conclusive to me. I am going to merge this for now, since it's a definite improvement over the current state.