Skip to content

Fix hash(::MutableTangent) on 32 bit#659

Merged
oxinabox merged 1 commit intomainfrom
ox/32
Jan 29, 2024
Merged

Fix hash(::MutableTangent) on 32 bit#659
oxinabox merged 1 commit intomainfrom
ox/32

Conversation

@oxinabox
Copy link
Member

Closes #658

having a UInt64 where I meant UInt broke dispatch and made it ignore the overload for the hash function

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a56d9c) 94.15% compared to head (d9304c7) 94.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files          15       15           
  Lines         976      976           
=======================================
  Hits          919      919           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxinabox oxinabox merged commit 935d625 into main Jan 29, 2024
@oxinabox oxinabox deleted the ox/32 branch January 29, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hash equality disagreement for MutableTangent on 32bit (/x86 CI)

2 participants