Skip to content

Handle RuleConfig and move to new world#4

Merged
oxinabox merged 6 commits intomasterfrom
ox/config
Jun 11, 2021
Merged

Handle RuleConfig and move to new world#4
oxinabox merged 6 commits intomasterfrom
ox/config

Conversation

@oxinabox
Copy link
Member

This is the companion to JuliaDiff/ChainRulesCore.jl#363
which was breaking for this, but only in a silly way.

This PR does 3 things.

1 . corrects the incorrect definition of the frule fallback

That ChainRulesCore PR as a complete side change corrected the fallback from frule(f, args...) to frule(dargs, f, args...).
Which never really mattered since everything was Any typed, but still was wrong, and turned on CROG (ChainRulesOverloadGeneration) depended on that

2. drop support for CRC (ChainRulesCore) 0.9 and remove deprecated things

We needed to drop that so we can talk about RuleConfigs for next part

3. Filter out rules that require RuleConfig

Technically we can ignore these, adding the config wasn't actually breaking.
But it does make the hook function spew out a ton of warnings.
So we would rather not.

In some future PR we will bring them back.
but will need to think a bit about the API.
The user already does a lot of filtering, so probably we will want to let them do this filtering also.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (9bf7935) to head (03b8233).

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   98.00%   96.29%   -1.71%     
==========================================
  Files           2        2              
  Lines          50       54       +4     
==========================================
+ Hits           49       52       +3     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oxinabox oxinabox merged commit f73a842 into master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants