Conversation
added 4 commits
June 4, 2021 09:41
mzgubic
commented
Jun 4, 2021
This reverts commit fba43c1.
oxinabox
approved these changes
Jun 4, 2021
mzgubic
commented
Jun 4, 2021
Member
Author
|
I've stupidly merged this before the Integration test finished. Turns out that some ChainRules tests get broken by this, so I've reverted the changes and tagged another patch version of ChainRulesTestUtils. Essentially what happens inside ChainRules is that there are some rrules for functions with optional arguments, e.g. function rrule(
::typeof(pinv),
x::AbstractVector{T},
tol::Real = 0,
) where {T<:Union{Real,Complex}}
y = pinv(x, tol)
function pinv_pullback(Δy)
∂x = sum(abs2, parent(y)) .* vec(Δy') .- 2real(y * Δy') .* parent(y)
return (NoTangent(), ∂x, ZeroTangent())
end
return y, pinv_pullback
endHere, even if |
mzgubic
added a commit
that referenced
this pull request
Jun 4, 2021
mzgubic
added a commit
that referenced
this pull request
Jun 4, 2021
oxinabox
added a commit
that referenced
this pull request
Jul 21, 2021
make rand_tangent give only nice numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167