Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 86.48% 86.84% +0.35%
==========================================
Files 1 1
Lines 74 76 +2
==========================================
+ Hits 64 66 +2
Misses 10 10 ☔ View full report in Codecov by Sentry. |
Maybe this should be fixed upstream and one should open issue in StaticArraysCore? It seems the docstring for |
|
That would certainly minimise the diff here. But (1) that means a chain of 4 PRs to get ForwardDiff free, and (2) from a quick look it wasn't just a few lines to move In the meantime, are there any actual downsides to this approach? Simple tests seem so say |
|
I opened an issue (JuliaArrays/StaticArraysCore.jl#12), so let's maybe see at least what the maintainers of StaticArraysCore think. |
|
Apparently the plan is to move Size to StaticArraysCore within the next few days, so I guess it would be good to wait with this PR until that's done. |
|
|
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Replaces StaticArrays with StaticArraysCore. Needed for JuliaDiff/ForwardDiff.jl#599
This means dropping Julia < 1.6.
There is a bit of a hack to get around the fact that
Sizeisn't available. Looks like this is well-tested.