Fix doctest failure#75
Merged
devmotion merged 2 commits intoJuliaDiff:masterfrom Dec 10, 2021
cossio:deterministic_jldoctest
Merged
Fix doctest failure#75devmotion merged 2 commits intoJuliaDiff:masterfrom cossio:deterministic_jldoctest
devmotion merged 2 commits intoJuliaDiff:masterfrom
cossio:deterministic_jldoctest
Conversation
The order in which DiffRules.diffrules() outputs things is not deterministic. This means this jldoctest can fail. Here we make it so that the output is deterministic.
Merged
Contributor
Author
|
The CI failures here might be related to the changes in Random in Julia 1.7? |
devmotion
reviewed
Dec 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 94.66% 95.74% +1.07%
==========================================
Files 2 2
Lines 150 141 -9
==========================================
- Hits 142 135 -7
+ Misses 8 6 -2
Continue to review full report at Codecov.
|
devmotion
approved these changes
Dec 10, 2021
Member
|
Thanks for the fix @cossio! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order in which DiffRules.diffrules() outputs things is not deterministic (because it depends on the order in which
keys(..)returns things).This means this jldoctest can fail:
Here we make it so that the output is deterministic.