Add diffrules for log1pmx and logmxp1#82
Conversation
|
Looks like JuliaStats/LogExpFunctions.jl#45 is actually a prerequisite. |
|
It's already tested automatically but maybe it's helpful to adjust the domain of inputs (both for the primal and the finite diff comparisons), similar to some other functions in runtests.jl. I don't remember the default domain by heart, so maybe it's not needed at all. Ironically, tests fail because the functions are not defined for |
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 96.96% 97.00% +0.03%
==========================================
Files 3 3
Lines 165 167 +2
==========================================
+ Hits 160 162 +2
Misses 5 5
Continue to review full report at Codecov.
|
devmotion
left a comment
There was a problem hiding this comment.
Thanks, looks good! I just have one suggestion to make finite differencing even less likely to fail.
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
….jl into logexpfuns_additions
devmotion
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
I'll merge and release once tests pass (and feel free to ping me if I forget it 🙂).
|
The MTK test errors are unrelated. |
This is supposed to fix JuliaStats/LogExpFunctions.jl#44.
There may be more optimal orders of operations for these derivatives.
Also, could someone assist me in what would be mandatory tests for these additions?