Skip to content

fix: allow (empty) sparse Hessians of linear functions#906

Merged
gdalle merged 3 commits intomainfrom
gd/zerohess
Nov 4, 2025
Merged

fix: allow (empty) sparse Hessians of linear functions#906
gdalle merged 3 commits intomainfrom
gd/zerohess

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Nov 4, 2025

Fixes JuliaDiff/SparseMatrixColorings.jl#281

Related: #857

Note that the fix is not necessary yet for unidirectional Jacobians because there is no postprocessing that can lead to zero groups

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.15%. Comparing base (9f50690) to head (60f7a75).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         134      134           
  Lines        8018     8022    +4     
=======================================
+ Hits         7870     7874    +4     
  Misses        148      148           
Flag Coverage Δ
DI 98.85% <100.00%> (+<0.01%) ⬆️
DIT 96.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga
Copy link
Copy Markdown
Contributor

It solves the issue on my side, good work!

@gdalle gdalle marked this pull request as ready for review November 4, 2025 20:02
@gdalle gdalle merged commit 01aa04a into main Nov 4, 2025
93 of 94 checks passed
@gdalle gdalle deleted the gd/zerohess branch November 14, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The option postprocessing=true crashes at Hessian preparation with DI.jl

2 participants