Conversation
|
Testing should now be set up, so you'll probably want to rebase this. |
ad02eee to
b458a23
Compare
|
Would it be possible to add a test specifically making use of this? |
|
Yes was just trying to figure out how (and where). I've added something, but my |
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 55.80% 55.98% +0.17%
==========================================
Files 21 21
Lines 2100 2106 +6
==========================================
+ Hits 1172 1179 +7
+ Misses 928 927 -1
Continue to review full report at Codecov.
|
43b426c to
86b4ece
Compare
oxinabox
left a comment
There was a problem hiding this comment.
You can test this using ChainRulesTestUtils if you wanted.
It supports testing these cases.
This basically LGTM.
I see no reason not to merge it once tests pass
|
CI failure is JuliaLang/julia#42125, will push a fix shortly if no one beats me to it. |
3055ce7 to
f16cb00
Compare
|
Just as a small comment: I'd generally always squash-merge PRs like this unless the commits are actually standalone changes. |
|
Sorry, will do, next time. |
This wants to add methods for
rrule_via_adandfrule_via_adfrom ChainRules.Need to figure out how to test this; so farNot sure anything is in the right place.rrule_via_addoes seem to work.