Fix repeated evaluation of fx0 in forward gradient computation#203
Merged
ChrisRackauckas merged 5 commits intoJuliaDiff:masterfrom Aug 16, 2025
Merged
Conversation
- Moved fx0 computation outside the loop in finite_difference_gradient! - Optimizes function evaluations from 2N to N+1 for forward differences - Maintains compatibility with both cached and uncached function values - Simplifies logic by eliminating conditional branches in the main loop Fixes JuliaDiff#202 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fx0 = f(x)inside the loop infinite_difference_gradient!Problem
As reported in #202, when computing forward differences for gradients, the function
f(x)was being evaluated N times inside the loop (once per iteration) in addition to the N evaluations for perturbed inputs, resulting in 2N total function evaluations.Solution
fx0 = f(x)computation outside the loopfx0 = typeof(fx) != Nothing ? fx : f(x)Test plan
Performance Impact
For a vector of length N, this reduces function evaluations by ~50%, providing significant performance improvement for expensive functions.
Fixes #202
🤖 Generated with Claude Code