Conversation
Contributor
|
I'm guessing the commit of |
Collaborator
Author
|
Jeez, it's up for 15 seconds and someone notices.. :P |
Closed
jrevels
reviewed
Mar 21, 2017
test/DualTest.jl
Outdated
| # exponent by one | ||
| intrand(T) = T == Int ? rand(2:10) : rand(T) | ||
|
|
||
| dualapprox(A, B) = value(A) ≈ value(B) && partials(A) ≈ partials(B) |
Member
There was a problem hiding this comment.
The (outdated-ly named) test_approx_diffnums defined below is what is used for this in the rest of the tests. Can you reuse/rename/rewrite that function instead?
Collaborator
Author
There was a problem hiding this comment.
Sure, didn't notice it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods gave the wrong partials but this was not noticed in the tests because
==only compares thevaluepart:Fix the bug and introduce a
dualapproxfunction to test approximate results of both the value and partial part:cc @tpapp