use SIMD.jl for explicit vectorization of partial operations#557
Merged
KristofferC merged 1 commit intomasterfrom Nov 19, 2021
Merged
use SIMD.jl for explicit vectorization of partial operations#557KristofferC merged 1 commit intomasterfrom
KristofferC merged 1 commit intomasterfrom
Conversation
Alternative to #555 Co-authored-by: Yingbo Ma <mayingbo5@gmail.com>
Collaborator
Author
|
Since this seems to have the same performance improvements as #555 (and also some better compile-time behavior) as well as not having to duplicate all the llvmcall logic that exists in SIMD.jl I think it is better to go with this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #555
Co-authored-by: Yingbo Ma mayingbo5@gmail.com
Using the benchmark in #555
I extracted the code from the benchmark in #555 (https://gist.github.com/KristofferC/a3915eec407491b7a4fc8a7d81c16fbe) and put it into https://uica.uops.info/. The result is (with some various tools) in cycles per iteration:
Explicit:
Master:
So it does seem that the strategy in #555 is quite good.