Skip to content

improve type stability in jacobian for a certain case #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
Nov 20, 2021
Merged

improve type stability in jacobian for a certain case #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Base.copy(cfg::AbstractConfig) = deepcopy(cfg)

Base.eltype(cfg::AbstractConfig) = eltype(typeof(cfg))

@inline chunksize(::AbstractConfig{N}) where {N} = N
@inline (chunksize(::AbstractConfig{N})::Int) where {N} = N

####################
# DerivativeConfig #
Expand Down
12 changes: 8 additions & 4 deletions src/jacobian.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ reshape_jacobian(result::DiffResult, ydual, xdual) = reshape_jacobian(DiffResult
# vector mode #
###############

function vector_mode_jacobian(f::F, x, cfg::JacobianConfig{T,V,N}) where {F,T,V,N}
function vector_mode_jacobian(f::F, x, cfg::JacobianConfig{T}) where {F,T}
N = chunksize(cfg)
ydual = vector_mode_dual_eval!(f, cfg, x)
ydual isa AbstractArray || throw(JACOBIAN_ERROR)
result = similar(ydual, valtype(eltype(ydual)), length(ydual), N)
Expand All @@ -152,7 +153,8 @@ function vector_mode_jacobian(f::F, x, cfg::JacobianConfig{T,V,N}) where {F,T,V,
return result
end

function vector_mode_jacobian(f!::F, y, x, cfg::JacobianConfig{T,V,N}) where {F,T,V,N}
function vector_mode_jacobian(f!::F, y, x, cfg::JacobianConfig{T}) where {F,T}
N = chunksize(cfg)
ydual = vector_mode_dual_eval!(f!, cfg, y, x)
map!(d -> value(T,d), y, ydual)
result = similar(y, length(y), N)
Expand All @@ -161,14 +163,16 @@ function vector_mode_jacobian(f!::F, y, x, cfg::JacobianConfig{T,V,N}) where {F,
return result
end

function vector_mode_jacobian!(result, f::F, x, cfg::JacobianConfig{T,V,N}) where {F,T,V,N}
function vector_mode_jacobian!(result, f::F, x, cfg::JacobianConfig{T}) where {F,T}
N = chunksize(cfg)
ydual = vector_mode_dual_eval!(f, cfg, x)
extract_jacobian!(T, result, ydual, N)
extract_value!(T, result, ydual)
return result
end

function vector_mode_jacobian!(result, f!::F, y, x, cfg::JacobianConfig{T,V,N}) where {F,T,V,N}
function vector_mode_jacobian!(result, f!::F, y, x, cfg::JacobianConfig{T}) where {F,T}
N = chunksize(cfg)
ydual = vector_mode_dual_eval!(f!, cfg, y, x)
map!(d -> value(T,d), y, ydual)
extract_jacobian!(T, result, ydual, N)
Expand Down
5 changes: 5 additions & 0 deletions test/JacobianTest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,4 +237,9 @@ end
@test ForwardDiff.jacobian(x -> eigvals(Symmetric(x*x')), [1.,2.]) ≈ [0 0; 2 4]
end

@testset "type stability" begin
g!(dy, y) = dy[1] = y[1]
@inferred ForwardDiff.jacobian(g!, [1.0], [0.0])
end

end # module