Skip to content

define sin/cos on Dual to use sincos #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
Nov 22, 2021
Merged

define sin/cos on Dual to use sincos #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ Base.float(d::Dual) = convert(float(typeof(d)), d)
###################################

for (M, f, arity) in DiffRules.diffrules(filter_modules = nothing)
if (M, f) in ((:Base, :^), (:NaNMath, :pow), (:Base, :/), (:Base, :+), (:Base, :-))
if (M, f) in ((:Base, :^), (:NaNMath, :pow), (:Base, :/), (:Base, :+), (:Base, :-), (:Base, :sin), (:Base, :cos))
continue # Skip methods which we define elsewhere.
elseif !(isdefined(@__MODULE__, M) && isdefined(getfield(@__MODULE__, M), f))
continue # Skip rules for methods not defined in the current scope
Expand Down Expand Up @@ -622,12 +622,19 @@ end
Dual{Tz}(muladd(x, y, value(z)), partials(z)) # z_body
)

# sincos #
# sin/cos #
#--------#
function Base.sin(d::Dual{T}) where T
s, c = sincos(value(d))
return Dual{T}(s, c * partials(d))
end

@inline sincos(x) = (sin(x), cos(x))
Copy link
Collaborator Author

@KristofferC KristofferC Nov 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this was here.

function Base.cos(d::Dual{T}) where T
s, c = sincos(value(d))
return Dual{T}(c, -s * partials(d))
end

@inline function sincos(d::Dual{T}) where T
@inline function Base.sincos(d::Dual{T}) where T
sd, cd = sincos(value(d))
return (Dual{T}(sd, cd * partials(d)), Dual{T}(cd, -sd * partials(d)))
end
Expand Down