Skip to content

CompatHelper: bump compat for SpecialFunctions to 2, (keep existing compat)#564

Merged
KristofferC merged 2 commits intomasterfrom
compathelper/new_version/2021-11-23-00-06-03-804-02214547686
Dec 13, 2021
Merged

CompatHelper: bump compat for SpecialFunctions to 2, (keep existing compat)#564
KristofferC merged 2 commits intomasterfrom
compathelper/new_version/2021-11-23-00-06-03-804-02214547686

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the SpecialFunctions package from 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 1.0 to 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 1.0, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@andreasnoack andreasnoack force-pushed the compathelper/new_version/2021-11-23-00-06-03-804-02214547686 branch from 11f5bc2 to d255014 Compare November 23, 2021 00:06
@KristofferC
Copy link
Collaborator

Oh, come on!!!!!!! 2.0 of SpecialFunctions for a technically breaking change.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #564 (d255014) into master (ab0e239) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files           9        9           
  Lines         868      868           
=======================================
  Hits          741      741           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e239...d255014. Read the comment docs.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I reran the tests to ensure that SpecialFunctions 2 is tested (DiffRules held it back initially). Unsurprisingly, tests did not fail.

@devmotion
Copy link
Member

@KristofferC I saw that the master branch contains some unreleased changes (v0.10.23...master) and also updated the julia bound to 1.6. Is it OK to merge this PR and make a release? Or is there a reason why you haven't released these changes yet?

I mainly wonder since ForwardDiff (and possibly some other packages) hold back SpecialFunctions in the tests in Distributions. And since Distributions actually required some changes I would like to properly test the fixes before merging the SpecialFunctions update over there.

@ranocha
Copy link
Contributor

ranocha commented Dec 3, 2021

Bump

@devmotion
Copy link
Member

@KristofferC is it OK with you if we merge and make a new release? Since Julia 1.6 became the LTS in the mean time it seems we don't have to worry about dropping support for Julia < 1.6 anymore.

@KristofferC
Copy link
Collaborator

Yes, but I think I will revert the SIMD stuff now since I don't think it has been properly tested to go into a release.

@KristofferC KristofferC merged commit 6aeb40f into master Dec 13, 2021
@devmotion
Copy link
Member

Thank you for releasing this PR @KristofferC!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants