CompatHelper: bump compat for SpecialFunctions to 2, (keep existing compat)#564
Conversation
11f5bc2 to
d255014
Compare
|
Oh, come on!!!!!!! 2.0 of SpecialFunctions for a technically breaking change. |
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 9 9
Lines 868 868
=======================================
Hits 741 741
Misses 127 127 Continue to review full report at Codecov.
|
devmotion
left a comment
There was a problem hiding this comment.
Looks good to me. I reran the tests to ensure that SpecialFunctions 2 is tested (DiffRules held it back initially). Unsurprisingly, tests did not fail.
|
@KristofferC I saw that the master branch contains some unreleased changes (v0.10.23...master) and also updated the I mainly wonder since ForwardDiff (and possibly some other packages) hold back SpecialFunctions in the tests in Distributions. And since Distributions actually required some changes I would like to properly test the fixes before merging the SpecialFunctions update over there. |
|
Bump |
|
@KristofferC is it OK with you if we merge and make a new release? Since Julia 1.6 became the LTS in the mean time it seems we don't have to worry about dropping support for Julia < 1.6 anymore. |
|
Yes, but I think I will revert the SIMD stuff now since I don't think it has been properly tested to go into a release. |
…03-804-02214547686
|
Thank you for releasing this PR @KristofferC! |
This pull request changes the compat entry for the
SpecialFunctionspackage from0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 1.0to0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 1.0, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.