Differentiation of eigen(::Symmetric)#575
Merged
KristofferC merged 6 commits intoJuliaDiff:masterfrom May 13, 2022
KnutAM:kam/eigendiff
Merged
Differentiation of eigen(::Symmetric)#575KristofferC merged 6 commits intoJuliaDiff:masterfrom KnutAM:kam/eigendiff
KristofferC merged 6 commits intoJuliaDiff:masterfrom
KnutAM:kam/eigendiff
Conversation
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
+ Coverage 85.39% 86.57% +1.17%
==========================================
Files 9 9
Lines 856 894 +38
==========================================
+ Hits 731 774 +43
+ Misses 125 120 -5
Continue to review full report at Codecov.
|
Contributor
Author
|
@andreasnoack, since you reviewed #513, may I ask for your opinion on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed nicely solved by @dlfivefifty in #513 (Discussed in #111 ), but I got an error when applying to the
eigenfunction and not theeigvalsfunctions that was tested.This PR takes the original code suggested in #111, as I think there is a mixup between
SymTridiagonalandSymmetricin the current implementation in master.Edit: It also enables the differentiation of a Symmetric StaticMatrix.