Skip to content

Add overloads for fld and cld#581

Merged
mcabbott merged 5 commits intomasterfrom
fldcld
Apr 24, 2022
Merged

Add overloads for fld and cld#581
mcabbott merged 5 commits intomasterfrom
fldcld

Conversation

@sethaxen
Copy link
Member

@sethaxen sethaxen commented Apr 8, 2022

This PR adds overloads for fld and cld, which currently throw a MethodError on master.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Math checks out

name = "ForwardDiff"
uuid = "f6369f11-7733-5829-9624-2563aa707210"
version = "0.10.25"
version = "0.10.26"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @KristofferC prefers to let a few changes to build up before cutting a release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already an open PR for making a new release (with the NaNMath compat PR) which nobody has reviewed for weeks...

@mcabbott mcabbott merged commit c85db12 into master Apr 24, 2022
@mcabbott mcabbott deleted the fldcld branch April 24, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants