DEFAULT_CHUNK_THRESHOLD is configurable via Preferences.jl#582
Merged
andreasnoack merged 2 commits intoJuliaDiff:masterfrom Aug 8, 2022
Merged
DEFAULT_CHUNK_THRESHOLD is configurable via Preferences.jl#582andreasnoack merged 2 commits intoJuliaDiff:masterfrom
andreasnoack merged 2 commits intoJuliaDiff:masterfrom
Conversation
andreasnoack
approved these changes
Aug 4, 2022
andreasnoack
reviewed
Aug 4, 2022
Member
andreasnoack
left a comment
andreasnoack
left a comment
There was a problem hiding this comment.
It would probably be a good idea to add this to the docs as well.
Contributor
Author
|
Thanks for the feedback, @andreasnoack. I added documentation to this feature. I should also say that as of FluxML/Zygote.jl#1213, the chunk size is exposed in Feel free to merge or close as you see fit. |
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 85.31% 86.71% +1.39%
==========================================
Files 9 9
Lines 858 903 +45
==========================================
+ Hits 732 783 +51
+ Misses 126 120 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: I would like to set the
DEFAULT_CHUNK_THRESHOLDfor a project that uses ForwardDiff.jl through Zygote.jl. Since configuring the chunk size used inZygote.forwarddiffis not supported by the Zygote API, I figured it may be okay to just expose this as a preference here.