Add test of second-order derivative of t -> abs(t)^2#650
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 86.98% 89.65% +2.67%
==========================================
Files 10 11 +1
Lines 891 967 +76
==========================================
+ Hits 775 867 +92
+ Misses 116 100 -16 ☔ View full report in Codecov by Sentry. |
Member
|
Any idea why we'd see these test failures? |
Member
Author
|
Not completely sure but I assume on Julia 1.9 it might just be due to different random numbers as only https://github.com/JuliaDiff/ForwardDiff.jl/actions/runs/5198679278/jobs/9375117936?pr=650#step:6:615 is failing. I don't know what's going on with nightly and the invalidations action. |
Member
Author
|
I guess the test failures were indeed random, tests on Julia 1.9 passed successfully after rerunning them. |
andreasnoack
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the example in JuliaDiff/DiffRules.jl#98 (comment) as a test, to avoid that upstream reintroduces this bug (DiffRules runs downstream tests of ForwardDiff).