Merged
Conversation
ChrisRackauckas
approved these changes
Dec 16, 2021
Member
Yeah that's odd and I don't know why, but I also know this is the right solution 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaDiff/DiffRules.jl#73 broke the tests since, similar to
polygammathe current DiffRules integration and test infrastructure can't deal with functions with two arguments of which one has to be an integer.Ideally, this would be tested properly but this PR is a temporary solution that requires minimal changes and fixes also the downstream tests in DiffRules.
It seems one problem with these functions is that the arguments are promoted when they are forwarded to ForwardDiff since everything is packed in a static vector - in these cases it would be better to not promote and work with the DiffRules definitions directly. I wonder why this is not done already and instead ReverseDiff calls ForwardDiff?