Fix vcat method ambiguity issues on Julia 1.8#210
Conversation
|
The test errors are known and caused by the latest release of DiffTests. I opened an issue and a PR a week ago. |
|
Can we upper bound the version of DiffTests? |
|
A bit unfortunate but I guess that's probably the fastest and easiest solution for now. I also checked JuliaDiff/DiffTests.jl#15 with this PR locally, and while it seems to fix the current issues it still fails due to some newly uncovered ambiguity issues (e.g., |
Codecov ReportBase: 85.09% // Head: 82.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 85.09% 82.19% -2.90%
==========================================
Files 18 18
Lines 1811 1528 -283
==========================================
- Hits 1541 1256 -285
- Misses 270 272 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
As expected, with DiffTests 0.1.1 all tests pass. |
Fixes the
vcattest errors due to a method ambiguity issue on Julia 1.8. These test errors are present on the master branch and show also up in other unrelated PRs.Maybe at some point one should clean up the
vcat/hcat/catdefinitions, similar to FluxML/Tracker.jl#128. But for now it seemed easier to just fix the reported method ambiguity issue.